From 438caa776d89426d19bf8624b841057608fb1bc4 Mon Sep 17 00:00:00 2001 From: ultrageopro Date: Thu, 13 Feb 2025 15:26:45 +0300 Subject: [PATCH 1/4] fix: neo4j MAX_CONNECTION_POOL_SIZE impl --- lightrag/kg/neo4j_impl.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lightrag/kg/neo4j_impl.py b/lightrag/kg/neo4j_impl.py index 587a9167..731b7cc1 100644 --- a/lightrag/kg/neo4j_impl.py +++ b/lightrag/kg/neo4j_impl.py @@ -55,9 +55,11 @@ class Neo4JStorage(BaseGraphStorage): PASSWORD = os.environ[ "NEO4J_PASSWORD", config.get("neo4j", "password", fallback=None) ] - MAX_CONNECTION_POOL_SIZE = os.environ.get( - "NEO4J_MAX_CONNECTION_POOL_SIZE", - config.get("neo4j", "connection_pool_size", fallback=800), + MAX_CONNECTION_POOL_SIZE = int( + os.environ.get( + "NEO4J_MAX_CONNECTION_POOL_SIZE", + config.get("neo4j", "connection_pool_size", fallback=800), + ) ) DATABASE = os.environ.get( "NEO4J_DATABASE", re.sub(r"[^a-zA-Z0-9-]", "-", namespace) From 1a0d7d6ecef8e4452d69c81f03d114cf575a3205 Mon Sep 17 00:00:00 2001 From: ultrageopro Date: Thu, 13 Feb 2025 15:29:18 +0300 Subject: [PATCH 2/4] fix: linting --- lightrag/api/lightrag_server.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lightrag/api/lightrag_server.py b/lightrag/api/lightrag_server.py index fe52f592..a442074d 100644 --- a/lightrag/api/lightrag_server.py +++ b/lightrag/api/lightrag_server.py @@ -101,6 +101,7 @@ def estimate_tokens(text: str) -> int: return int(tokens) + def get_default_host(binding_type: str) -> str: default_hosts = { "ollama": os.getenv("LLM_BINDING_HOST", "http://localhost:11434"), From a50cdbc177a302df6f58b57ac19fbc7ef40d7b35 Mon Sep 17 00:00:00 2001 From: ultrageopro Date: Thu, 13 Feb 2025 18:07:24 +0300 Subject: [PATCH 3/4] fix: incorrect usage of os.environ.get method in neo4j --- lightrag/kg/neo4j_impl.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lightrag/kg/neo4j_impl.py b/lightrag/kg/neo4j_impl.py index 731b7cc1..b0839172 100644 --- a/lightrag/kg/neo4j_impl.py +++ b/lightrag/kg/neo4j_impl.py @@ -48,13 +48,13 @@ class Neo4JStorage(BaseGraphStorage): self._driver = None self._driver_lock = asyncio.Lock() - URI = os.environ["NEO4J_URI", config.get("neo4j", "uri", fallback=None)] - USERNAME = os.environ[ + URI = os.environ.get("NEO4J_URI", config.get("neo4j", "uri", fallback=None)) + USERNAME = os.environ.get( "NEO4J_USERNAME", config.get("neo4j", "username", fallback=None) - ] - PASSWORD = os.environ[ + ) + PASSWORD = os.environ( "NEO4J_PASSWORD", config.get("neo4j", "password", fallback=None) - ] + ) MAX_CONNECTION_POOL_SIZE = int( os.environ.get( "NEO4J_MAX_CONNECTION_POOL_SIZE", From 8773ad983f8d42ed7cea1f91c963d84b70c83d78 Mon Sep 17 00:00:00 2001 From: ultrageopro Date: Thu, 13 Feb 2025 18:09:24 +0300 Subject: [PATCH 4/4] fix: incorrect usage of os.environ.get in PASSWORD --- lightrag/kg/neo4j_impl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lightrag/kg/neo4j_impl.py b/lightrag/kg/neo4j_impl.py index b0839172..e9a53110 100644 --- a/lightrag/kg/neo4j_impl.py +++ b/lightrag/kg/neo4j_impl.py @@ -52,7 +52,7 @@ class Neo4JStorage(BaseGraphStorage): USERNAME = os.environ.get( "NEO4J_USERNAME", config.get("neo4j", "username", fallback=None) ) - PASSWORD = os.environ( + PASSWORD = os.environ.get( "NEO4J_PASSWORD", config.get("neo4j", "password", fallback=None) ) MAX_CONNECTION_POOL_SIZE = int(