From 905699429281c576f9abbd29ae8c247b64bcda29 Mon Sep 17 00:00:00 2001 From: yangdx Date: Tue, 4 Mar 2025 01:28:08 +0800 Subject: [PATCH] Deprecate and remove logging parameters in LightRAG. - Set log_level and log_file_path to None by default - Issue warnings if deprecated parameters are used - Maintain backward compatibility with warnings --- lightrag/lightrag.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lightrag/lightrag.py b/lightrag/lightrag.py index 114b5735..21688b7d 100644 --- a/lightrag/lightrag.py +++ b/lightrag/lightrag.py @@ -88,8 +88,8 @@ class LightRAG: # Logging (Deprecated, use setup_logger in utils.py instead) # --- - log_level: int = field(default=logger.level) - log_file_path: str = field(default=os.path.join(os.getcwd(), "lightrag.log")) + log_level: int | None = field(default=None) + log_file_path: str | None = field(default=None) # Entity extraction # --- @@ -268,21 +268,23 @@ class LightRAG: ) # Handle deprecated parameters - kwargs = self.__dict__ - if "log_level" in kwargs: + if self.log_level is not None: warnings.warn( "WARNING: log_level parameter is deprecated, use setup_logger in utils.py instead", UserWarning, stacklevel=2, ) - # Remove the attribute to prevent its use - delattr(self, "log_level") - if "log_file_path" in kwargs: + if self.log_file_path is not None: warnings.warn( "WARNING: log_file_path parameter is deprecated, use setup_logger in utils.py instead", UserWarning, stacklevel=2, ) + + # Remove these attributes to prevent their use + if hasattr(self, "log_level"): + delattr(self, "log_level") + if hasattr(self, "log_file_path"): delattr(self, "log_file_path") initialize_share_data()