gardel/lightrag
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix update status handling bugs in drop function of json kv storage

Browse Source
This commit is contained in:
yangdx
2025-04-01 13:53:02 +08:00
parent e83f6c0c63
commit ff5c7182da
2 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lightrag/kg/json_doc_status_impl.py
View File

@@ -141,9 +141,14 @@ class JsonDocStatusStorage(DocStatusStorage):
None None
""" """
async with self._storage_lock: async with self._storage_lock:
any_deleted = False
for doc_id in doc_ids: for doc_id in doc_ids:
self._data.pop(doc_id, None) result = self._data.pop(doc_id, None)
await set_all_update_flags(self.namespace) if result is not None:
any_deleted = True
if any_deleted:
await set_all_update_flags(self.namespace)
async def drop(self) -> dict[str, str]: async def drop(self) -> dict[str, str]:
"""Drop all document status data from storage and clean up resources """Drop all document status data from storage and clean up resources
@@ -160,7 +165,9 @@ class JsonDocStatusStorage(DocStatusStorage):
""" """
try: try:
async with self._storage_lock: async with self._storage_lock:
self._data.update({}) self._data.clear()
await set_all_update_flags(self.namespace)
await self.index_done_callback() await self.index_done_callback()
logger.info(f"Process {os.getpid()} drop {self.namespace}") logger.info(f"Process {os.getpid()} drop {self.namespace}")
return {"status": "success", "message": "data dropped"} return {"status": "success", "message": "data dropped"}

13
lightrag/kg/json_kv_impl.py
View File

@@ -140,9 +140,14 @@ class JsonKVStorage(BaseKVStorage):
None None
""" """
async with self._storage_lock: async with self._storage_lock:
any_deleted = False
for doc_id in ids: for doc_id in ids:
self._data.pop(doc_id, None) result = self._data.pop(doc_id, None)
await set_all_update_flags(self.namespace) if result is not None:
any_deleted = True
if any_deleted:
await set_all_update_flags(self.namespace)
async def drop_cache_by_modes(self, modes: list[str] | None = None) -> bool: async def drop_cache_by_modes(self, modes: list[str] | None = None) -> bool:
"""Delete specific records from storage by by cache mode """Delete specific records from storage by by cache mode
@@ -183,7 +188,9 @@ class JsonKVStorage(BaseKVStorage):
""" """
try: try:
async with self._storage_lock: async with self._storage_lock:
self._data.update({}) self._data.clear()
await set_all_update_flags(self.namespace)
await self.index_done_callback() await self.index_done_callback()
logger.info(f"Process {os.getpid()} drop {self.namespace}") logger.info(f"Process {os.getpid()} drop {self.namespace}")
return {"status": "success", "message": "data dropped"} return {"status": "success", "message": "data dropped"}